GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.
https://graphite.rs
Apache License 2.0
7.31k stars 387 forks source link

Safari rendering bug causes upward offset of tool shelf color picker #1687

Open Keavon opened 3 months ago

Keavon commented 3 months ago

There is a Safari bug affecting our color picker popover for the tool shelf's working colors input. It causes Safari to render the popover by about a 130px upward offset. However, the click targets and devtools hover highlight visualizations for the elements in this popover do show up in the correct location, so this only affects how Safari paints the content.

https://github.com/GraphiteEditor/Graphite/assets/4388688/575d079d-803d-4fc5-8194-8ec977142a32

We need to investigate this further, ideally create a minimal reproduction test case, and report this. Then hope it's fixed. Or, find a particular way that we can change things to mitigate this on our end.

This is tested on Safari 16.5. container-type was added in Safari 16 (released 2022-09-12).

Keavon commented 3 months ago

Maybe related, as this is the only webkit bug report I can find about container-type: https://bugs.webkit.org/show_bug.cgi?id=256047