search

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.
https://graphite.rs
Apache License 2.0
7.3k stars 386 forks source link

Show artboard names in viewport #1706

Open 0HyperCube opened 3 months ago

0HyperCube commented 3 months ago

Currently it is possible to rename an artboard by double clicking in the layer tree. However this change is not reflected in the viewport, where it is still titled "Artboard". artboard with incorrect name in viewport

See impl GraphicElementRendered for Artboard for the artboard rendering code. This change necessitates the passing of the name string into the graph execution context, whereas currently it is just visible as metadata on the document graph and so not sent to the actual node implementations at all. If the ConstructLayerNode got the layer name as input then it could apply the name to the passed in GraphicElement, which would involve storing the string in the Artboard struct and then retrieving that during rendering.

ysrtyfn commented 2 weeks ago

Hello, I would like to work on this issue. If it is OK, I can send a draft PR and start working.

Keavon commented 2 weeks ago

This should be available, so please open a PR for it when you have some in-progress code, thanks!