search

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.
https://graphite.rs
Apache License 2.0
7.3k stars 386 forks source link

Change PWA theme-color for frontend to adhere to system theme #1716

Closed smarizvi110 closed 3 months ago

smarizvi110 commented 3 months ago

Resolves #1338

Keavon commented 3 months ago

Your PR changes the indentation to tabs in one, but not both, files. Could you please either make them both tabs or keep them as both spaces?

smarizvi110 commented 3 months ago

Your PR changes the indentation to tabs in one, but not both, files. Could you please either make them both tabs or keep them as both spaces?

Thanks for the heads up, done.

Keavon commented 3 months ago

Except now you replaced all the indentation in index.html...

smarizvi110 commented 3 months ago

Except now you replaced all the indentation in index.html...

Ah sorry. Let me just fix that. I must've accidentally configured the indentations to be more like rust's way for that too. Fixed now. Thank you for the patience 🙏

Keavon commented 3 months ago

Where did you find that "auto" as a value is a solution to #1338? I can't find any reference to that value in my research, and it looks like this issue that would automatically adapt to light and dark themes is still an open discussion that, I don't think, has been implemented into browsers. I'm concerned this isn't a real solution to the issue (and for that reason I'm going to temporarily close this but please reply and I'm happy to reopen it). Thanks.

smarizvi110 commented 3 months ago

Where did you find that "auto" as a value is a solution to #1338? I can't find any reference to that value in my research, and it looks like this issue that would automatically adapt to light and dark themes is still an open discussion that, I don't think, has been implemented into browsers. I'm concerned this isn't a real solution to the issue (and for that reason I'm going to temporarily close this but please reply and I'm happy to reopen it). Thanks.

Stumbled across this as a fix that could work for PWAs by just trying it. It seemed to work on my end, and the PWA would change the title bar color in accordance with the theme. But yes, I agree that it doesn't seem to be a widely supported option and the issue you mentioned is definitely worth looking in to. I'll be on the lookout for a better solution with regards to the issue you mentioned, but this PR should indeed remain closed for now. Thanks!