Loosen the Graphene type system to allow contravariant function arguments

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.

https://graphite.rs

Apache License 2.0

7.3k stars 386 forks source link

Loosen the Graphene type system to allow contravariant function arguments #1740

Closed TrueDoctor closed 1 month ago

TrueDoctor commented 1 month ago

This partially implements the contravariant function arguments RFC by permitting to call nodes with any input if the node expects to receive () as an input

Closes #1741

Keavon commented 1 month ago

Load Image regression (works in master), however this works when the Transform node isn't included (you just have to zoom into the 1x1 image at the artboard origin):
Noise Pattern has the same regression:
Text doesn't have regressions, but oddly just... doesn't work when you add it from the node graph, but it does work when you add it from the Text tool and give it the same options. This is also the case in master, but I'm mentioning it here regardless.

Keavon commented 1 month ago

I think I'll merge this now, though, and let you solve those regressions in a followup PR. Since I'd like to do a release today.