Closed Kukkarmutta closed 1 week ago
Hi, welcome! Please be sure to run cargo fmt
, and set up your text editor to run it automatically when saving the file. (This should already be the default in VS Code if you have the Rust Analyzer extension installed, but you'll have to figure out how to do that in other editors yourself.) Once you commit the formatted code, I can begin reviewing this. Thanks!
Hello Again. Although I had rust-analyser installed, I have run the formatting command. Kindly review and let me know if any further changes are required.
Edit: I assume by formatting you meant that the function parameters are now placed on a new line. After running cargo fmt it still puts them in a newer line which was not how it was formatted in the original code. I've fixed this manually for now, but is there a way to configure fmt command to place them inline?
!build
It looks like the code doesn't compile. Have you thoroughly tested everything, including both the intended functionality and other likely regressions? I'll mark this as a draft until you have it working. Thanks!
When I tried to fix it manually idk what happened and some lines got deleted :') (i noticed that much later)
im fixing that issue and will submit it in a few minutes
Closes #2083
Hello, this is my first contribution. Hope the issue is resolved as intended. If I've made any mistake or there is room for improvement, do let me know :)
Details: