search

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.
https://graphite.rs
Apache License 2.0
9.47k stars 457 forks source link

CSS fix for Preferences Dialog #2104

Closed RounakJoshi09 closed 1 week ago

RounakJoshi09 commented 2 weeks ago

This is added in order let the elements fill the space in the widget span row, this is indeed necessary here, because , the width is available in the dialog, but the elements are aligned to the start, and not utilizing the width properly, in order to fix this in a responsive way, I have added the justify-content css property, which uses the width available for the WidgetSpan.

Fixes #2103

Screen shots after the fix image image

0HyperCube commented 1 week ago

Resolved by https://github.com/GraphiteEditor/Graphite/commit/99cf8f0c4f91a051b59fc2c9e5cc6c7417bdd74b.

Keavon commented 1 week ago

@RounakJoshi09 Just to chime in about why I didn't merge this PR, unfortunately your proposed CSS change would have a large impact on many parts of the UI beyond just the misaligned settings dialog content. But I'm also going to quickly check if it would have made desirable improvements or if it broke things (just by looking at the code, I'm having to assume the latter is more likely, but I'll check by triggering a build real quick).

Keavon commented 1 week ago

!build

github-actions[bot] commented 1 week ago
📦 Build Complete for a534bb80b2199c966a12b79ae69e6d62a67aac8b
https://08bb7d0e.graphite.pages.dev