search

GrappleGQL / gatsby-source-wagtail

Plugin for sourcing Gatsby data from Wagtail CMS
17 stars 12 forks source link

Fix: latest gatsby version breaks this package develop and build scripts #25

Closed fabienheureux closed 3 years ago

fabienheureux commented 3 years ago

In the latest Gatsby version (2.24.63 for me), there are errors related to reactRuntime being undefined. You can learn more in these issues https://github.com/gatsbyjs/gatsby/issues/26736 https://github.com/prismicio/gatsby-source-graphql-universal/issues/13

This PR takes the babel-loader.js file from gatsby-source-graphql-universal (in this PR https://github.com/prismicio/gatsby-source-graphql-universal/pull/12) I thought that using a not so minified version of babel-loader.js could help debug it in the future.

fabienheureux commented 3 years ago

@NathHorrigan do you think you could review this PR ? Or any maintainer 😊 ? Thanks !

NathHorrigan commented 3 years ago

Nice Work. I really wish Gatsby wasn't a mess ;)

tbrlpld commented 3 years ago

Are you able to run your app with the plugin installed now? I just started a completely fresh project (with gatsby-source-wagtail installed from Github) and gatsby develop and gatsby build are failing with the following error message:

success run page queries - 0.021s - 6/6 291.58/s

 ERROR #98123  WEBPACK

Generating development JavaScript bundle failed

Unknown option: .rootDir. Check out https://babeljs.io/docs/en/babel-core/#options for more information about options.

File: .cache/polyfill-entry.js

 ERROR #98123  WEBPACK

Generating development JavaScript bundle failed

Unknown option: .rootDir. Check out https://babeljs.io/docs/en/babel-core/#options for more information about options.

File: .cache/app.js

failed Building development bundle - 0.947s

Not sure if this is the same error or a new one 🤦‍♂️

Here is the system output:

$ gatsby info

  System:
    OS: macOS 10.15.7
    CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.3.1 - ~/.nvm/versions/node/v12.3.1/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.7 - ~/.nvm/versions/node/v12.3.1/bin/npm
  Languages:
    Python: 3.8.2 - /Users/tibor/.pyenv/shims/python
  Browsers:
    Chrome: 85.0.4183.121
    Firefox: 81.0
    Safari: 14.0
  npmPackages:
    gatsby: ^2.24.67 => 2.24.67
    gatsby-image: ^2.4.20 => 2.4.20
    gatsby-plugin-manifest: ^2.4.33 => 2.4.33
    gatsby-plugin-offline: ^3.2.30 => 3.2.30
    gatsby-plugin-react-helmet: ^3.3.12 => 3.3.12
    gatsby-plugin-sharp: ^2.6.38 => 2.6.38
    gatsby-source-filesystem: ^2.3.32 => 2.3.32
    gatsby-source-wagtail: git+https://github.com/GrappleGQL/gatsby-source-wagtail.git => 0.5.1
    gatsby-transformer-sharp: ^2.5.16 => 2.5.16
  npmGlobalPackages:
    gatsby: 2.24.67
tbrlpld commented 3 years ago

Using "gatsby": "2.24.51" as a fixed dependency does resolve the issue (just as it does in https://github.com/gatsbyjs/gatsby/issues/26736)

fabienheureux commented 3 years ago

Just noticed the merge, thanks a lot @NathHorrigan !

@tbrlpld I am not sure that stick to an old version of gatsby is a good solution, you should better open a new issue 😉

tbrlpld commented 3 years ago

@fabienheureux Haha, no, it definitely is not. It was only a quick fix so I could move on with my work. Thought I'd document it here so others could find it.

Are you able to start a brand new project with latest Gatsby and this package installed?

Happy to add a new issue. Just wasn't sure if these are maybe connected as the failing commands were the same.

fabienheureux commented 3 years ago

Ha yes, makes sense.

I will try today, but honestly, I have recurring issues with gatsby while creating new projects or after dependency updates...so I wouldnt be surprised if I reproduce your issue.