Graqr / Threshr

real-time grocery query java library
GNU General Public License v3.0
1 stars 2 forks source link

mislabeled and duplicated tests in controller spec #134

Open Jonathan-Zollinger opened 2 weeks ago

Jonathan-Zollinger commented 2 weeks ago

Summary

tests "query pdp for #tcinArg tcin strings"() and "query product summaries with no error tcin type arg"() are duplicates (pdp test is mislabeled). #133 is also heavily applicable

both tests excerpt ```groovy void "query pdp for #tcinArg tcin strings"() { when: if (count == 1){ threshrController.fetchProductSummaries(targetStore, tcinArg as String) }else { threshrController.fetchProductSummaries(targetStore, tcinArg as String[]) } then: noExceptionThrown() where: tcinArg | count tcin.getTcins().split(",")[0] | 1 tcin.getTcins().split(",") | 2 } void "query product summaries with no error tcin type arg"() { when: threshrController.fetchProductSummaries(targetStore, tcinArg) then: noExceptionThrown() where: tcinArg | _ tcin | _ new Tcin(tcin.getTcins().split(",")[0]) | _ } ```