Graqr / Threshr

java sdk for target's grocery api
GNU General Public License v3.0
1 stars 2 forks source link

Target store id to be included as an option #18

Closed Jonathan-Zollinger closed 6 months ago

Jonathan-Zollinger commented 9 months ago

Summary

target stores require a lot of data for the product summaries request. the class' toString method shows this idea of too much data.

public String toString() {
    return String.join("&", new String[]{
            "store_id=" + locationId,
            "zip=" + postalCode,
            "state=" + region,
            "latitude=" + latitude,
            "longitude=" + longitude,
            "scheduled_delivery_store_id=" + locationId,
            "required_store_id=" + locationId,
            "has_required_store_id=true"
    });
}

Proposed Solution

there's an api which provides all this information. adding this endpoint and caching the information could solve this need

Alternative

keep our own database of target stores with all their information to look up

Additional Context

requirement:

Code of Conduct