Graqr / Threshr

java sdk for target's grocery api
GNU General Public License v3.0
1 stars 2 forks source link

Send Target API call as query params. #21

Closed Jonathan-Zollinger closed 8 months ago

Jonathan-Zollinger commented 9 months ago

Summary

right now the get requests consist of a small count of parameters in order to make calls simpler (with pojo's and overridden toString methods).

Proposed Solution

all the %2C and %2F found in the api call are encoded, so take advantage of that.

for example, the tcins could just be given a comma delimited list of the id's as a single String. the page could be sent by its ID (or omitted entirely, this is just an example) page=%2Fc%2Fk4uyq is what we pass now, it coule be /c/k4uyq

Alternative

just keep it as is, it's working - just more work to maintain

Additional Context

the following is taken from micronaut's docs

Requirements

Code of Conduct