Graqr / Threshr

real-time grocery query java library
GNU General Public License v3.0
1 stars 2 forks source link

Feature/obfuscate config #55

Closed Jonathan-Zollinger closed 5 months ago

Jonathan-Zollinger commented 5 months ago

name: Submit a New Feature Pull Request about: Introduce a new feature, refactor code or fix a bug with a pull request title: Feature/obfuscate config labels: '' assignees: ''


Purpose of this Pull Request

removes configuration specifics from the application properties file; improve security

How does this Pull Request address its purpose?

values for an api key is procured via environment variable

this requires environment variables to include THRESHR_KEY and THRESHR_CHANNEL assignments, as noted in the .env file, as well as javadocs for the client and controller classes

Iterate what tests have been added to maintain complete code coverage.

no tests are added since any tests calling this api (which are many) rely on this configuration to work properly.