Graqr / Threshr

java sdk for target's grocery api
GNU General Public License v3.0
1 stars 2 forks source link

refactor ThreshrControllerSpec to use a table for values #67

Closed Jonathan-Zollinger closed 6 months ago

Jonathan-Zollinger commented 7 months ago

Summary

right now the tests use a signle tcinList object.

Why Test?

there could be cases where the tcins irl aren't compatible with our pojo validation.

Proposed Solution

emulate the way place and page are tested, where their data is externally sourced with sensible default file / args

Why Proposed Solution

it's flexible enough to change down the road, even at time of the test, but uses a well rounded default for normal testing.

Alternative

dont change anything, or add more values in-file.

Test Requirements

Additional Context

page test with loaded data

Code of Conduct

Jonathan-Zollinger commented 6 months ago

moved #103 to its own task as this data isn't available to be used in testing yet.