search

Grasia / dao-analyzer

DAO visualization tool
GNU General Public License v3.0
38 stars 8 forks source link

Recover assets from vault in Aragon #70

Open daviddavo opened 2 years ago

daviddavo commented 2 years ago

Our current method to recover assets is to get the balance of the DAO address. There are some platforms, like Aragon, that store assets in another app and not the core, thus, having a different address where the balance is stored.

daviddavo commented 2 years ago

It seems that this problem occurs because we pass a too high value to millify. (That value being 7.4e68. I don't know if it is possible to have that much money, so I think we have an error at some point in the cache_scripts. This fix will be going as v8.2.1 and directly in the master branch

daviddavo commented 2 years ago

There is a DAO with an incredible amount of ROC, which, according to CryptoCompare has a value of 0.0005074 ETH (even If it has not been used in 3 years).

This is the recovery vault with addr 0x0, aka a burn address...

I think we should keep a list of "burn addresses" to delete from our dataframes. Or should we keep this info? @javiag

javiag commented 2 years ago

It sounds very reasonable.

My main concern is how do we know that the address is a "burn address". Is there a curated list somewhere? Can users declare that an address is a burn address?

In addition, I'd like you to document carefully the process in the code, but also to explain it in the documentation (I don't know if in the about page, because it is too technical).

daviddavo commented 2 years ago

Update: The problem seems to be that there are a lot of DAOs with the recoveryAddress set to 0x0. An example of that would be MyBit. If you go to MyBit on dao-analyzer, it doesn't display anything (it fails). Because it has the 0x0 vault address, it tries to display the 7.4e68 value, and it fails... Furthermore, the "Tokens without fiat equivalence" thing is incorrect.

I don't quite understand how Aragon DAOs finances go... Currently, we are using the recoveryAddress, but there are some daos which don't have a recoveryAddress, but have the finance application so they have some value stored. Others have the tokens stored in the agent...

Here are the installed apps for MyBit

In the meantime, I think setting the vault address from 0x0 to NaN should suffice.

daviddavo commented 2 years ago

We should at least put a disclaimer because the assets are only on the recovery vault

daviddavo commented 1 year ago

This is a "feature" of all DAO platforms (even though in Aragon is the problem is more prominent because of "apps"). Perhaps we should still put a disclaimer, or even add a "caption" to every graph explaining it a bit. But that would be another issue...