Switch order of literals to prevent NullPointerException

[pixeeai]

Description

This change defensively switches the order of literals in comparison expressions to ensure that no null pointer exceptions are unexpectedly thrown. Runtime exceptions especially can cause exceptional and unexpected code paths to be taken, and this can result in unexpected behavior.

Both simple vulnerabilities (like information disclosure) and complex vulnerabilities (like business logic flaws) can take advantage of these unexpected code paths.

Our changes look something like this:

  String fieldName = header.getFieldName();
  String fieldValue = header.getFieldValue();
- if(fieldName.equals("requestId")) {
+ if("requestId".equals(fieldName)) {
    logRequest(fieldValue);
  }

More reading

* [https://cwe.mitre.org/data/definitions/476.html](https://cwe.mitre.org/data/definitions/476.html) * [https://en.wikibooks.org/wiki/Java_Programming/Preventing_NullPointerException](https://en.wikibooks.org/wiki/Java_Programming/Preventing_NullPointerException) * [https://rules.sonarsource.com/java/RSPEC-1132/](https://rules.sonarsource.com/java/RSPEC-1132/)

Powered by: pixeebot (codemod ID: pixee:java/switch-literal-first)

Type of changes

• [ ] Bug fix
• [ ] New feature
• [x] Enhancement
• [ ] Documentation

Checklist:

• [x] My code follows the style guidelines of this project
• [x] My pull request is unique and no other pull requests have been opened for these changes
• [x] I have read the Contributing note and Code of conduct
• [x] I am responsible for any copyright issues with my code if it occurs in the future.

[pixeeai]

FYI - This change was autogenerated from a new trending GitHub app - called Pixeebot. A code-quality GitHub App; like Dependabot, but for source code.