search

Gravemind / tt-rss-feedlish-theme

Feedly-ish theme for Tiny Tiny RSS 18.12+
GNU General Public License v3.0
36 stars 1 forks source link

Feed name button not present when looking at specific feed #4

Closed jamespo closed 5 years ago

jamespo commented 5 years ago

If I look at a specific feed the button with the feed name for each article isn't there - there is a gap instead

image

The button isn't there with the default theme either, but there's no gap

Gravemind commented 5 years ago

Yes, I couldn't find a proper solution yet.

I think it's a change after 18.8: now, tt-rss emits the emplacement for the feed name, but the name inside is empty. At 18.8, I think the whole emplacement wasn't emitted at all.

If I cannot find a solution, I might send a couple Issues or PRs to tt-rss...

levito commented 5 years ago

I kind of solved this by setting the width not on .feed but on the contained .feed a while also hiding .feed a:empty. See https://github.com/levito/tt-rss-feedly-theme/commit/a40709265593f3912381487375023ce9d290cb63.

The downside of this is that feed names don't shrink anymore if they are shorter. For me this was an acceptable compromise.

Gravemind commented 5 years ago

Thanks @levito ! For now, I personally prefer to keep the short feed title version.

I made a PR to tt-rss with the most PR-worthy fix I found.

Gravemind commented 5 years ago

tt-rss has now a neat is-vfeed attribute (Thanks fox ) to deal with this issue in themes.

@levito: here is how I used it.

levito commented 5 years ago

Awesome, thanks! I also use it now