[DTN-01S] Inexistent Sanitization of Input Addresses

[0xfornax]

DTN-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		DebtToken.sol:L26-L34

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

function setAddresses(
    address _borrowerOperationsAddress,
    address _stabilityPoolAddress,
    address _vesselManagerAddress
) public onlyOwner() {
    borrowerOperationsAddress = _borrowerOperationsAddress;
    stabilityPoolAddress = _stabilityPoolAddress;
    vesselManagerAddress = _vesselManagerAddress;
}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

[0xfornax]

Fixed.