[CLP] Add collapse example to a lens

joofio commented 9 months ago

I suggest: if adult, (check birthdate IPS), then greyout children sections

aalonsolopez commented 8 months ago

Hi @joofio. I was thinking on a easier PoC: If man, then greyout pregnancy sections. Is ok for you?

joofio commented 8 months ago

i was trying to avoid that issue, but assuming biological gender in order to be more accurate, i think it can work as well as with age. (over 75 - checked google ahaha)

aalonsolopez commented 8 months ago

hahahahhahahah perfect! I'll work on that

aalonsolopez commented 8 months ago

@joofio @jkiddo

I have a lense with the collapse functionality as a draft on our development server. You can test if you want.

Conditions: Works if patient is not biologically a woman or if being a woman is 75 years old or more.

POST https://gravitate-health.lst.tfo.upm.es/focusing/focus/bundlepackageleaflet-2d49ae46735143c1323423b7aea24165?preprocessors=preprocessing-service-manual&lenses=lens-selector-mvp2_pregnancy-collapse&patientIdentifier=Pedro-1

Any feedback is welcome :)

joofio commented 8 months ago

content-type: application/json is working in dev?

aalonsolopez commented 8 months ago

Hello and happy new year! Yes, should be working.

joofio commented 8 months ago

happy new year :)

POST https://gravitate-health.lst.tfo.upm.es/focusing/focus/bundlepackageleaflet-2d49ae46735143c1323423b7aea24165?preprocessors=preprocessing-service-manual&lenses=lens-selector-mvp2_pregnancy-collapse&patientIdentifier=Pedro-1
content-type: application/json

This results as the same as without the content type. something changed?

aalonsolopez commented 8 months ago

Oh, its not Content-Type, its Accept imagen

joofio commented 8 months ago

of course now it works! Thanks. This will be merged into pregnancy?

aalonsolopez commented 8 months ago

It can be left out as a separate lense, which in my opinion doesn't make sense, or be merged as you said. What you prefer the most.

joofio commented 8 months ago

Merged its better.

--

Alejandro Alonso López @.***> escreveu em ter., 9/01/2024 às 08:18 :

It can be left out as a separate lense, which in my opinion doesn't make sense, or be merged as you said. What you prefer the most.

— Reply to this email directly, view it on GitHub https://github.com/Gravitate-Health/focusing-manager/issues/27#issuecomment-1882595315, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMJVUALVKLW4MAGDGH4DVDYNT4O3AVCNFSM6AAAAABAK6KZS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSGU4TKMZRGU . You are receiving this because you were mentioned.Message ID: @.***>

aalonsolopez commented 8 months ago

Ok so, as we are waiting for the review to finish, I cannot commit it to main, so I will create a new branch to do the "lense merge" task and then merge it to the develop branch to mark it as "ready to deploy on production". I will make you the reviewer of the PR just to make you know I've finished.

joofio commented 8 months ago

Wait I didn’t understand .

I was saying merge into the pregnancy lens, right ?

--

Alejandro Alonso López @.***> escreveu em ter., 9/01/2024 às 09:11 :

Ok so, as we are waiting for the review to finish, I cannot commit it to main, so I will create a new branch to do the "lense merge" task and then merge it to the develop branch to mark it as "ready to deploy on production". I will make you the reviewer of the PR just to make you know I've finished.

— Reply to this email directly, view it on GitHub https://github.com/Gravitate-Health/focusing-manager/issues/27#issuecomment-1882671328, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMJVUDFHD6MJX4K6LK7CULYNUCT5AVCNFSM6AAAAABAK6KZS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSGY3TCMZSHA . You are receiving this because you were mentioned.Message ID: @.***>

aalonsolopez commented 8 months ago

Yes @joofio, but we still cannot upload this change to production.

joofio commented 8 months ago

ok but we can check the "merged" lens in dev right? now its "lens-selector-mvp2_pregnancy-collaps" correct?

aalonsolopez commented 8 months ago

No, that lens does not exist anymore. The lens with the collapse is "lens-selector-mvp2_pregnancy", but with applied changes. You can see the changes on https://github.com/Gravitate-Health/lens-selector-mvp2/pull/12

joofio commented 8 months ago

i think there is a bug, the class in style is collapsed and the attribute given is collapse (no "d")

aalonsolopez commented 8 months ago

Totally true, sorry, I fix it right now

aalonsolopez commented 8 months ago

Now working on dev, sorry for that typo

joofio commented 7 months ago

seems ok. Should we pass the mvp2 naming to mvp3?

joofio commented 5 months ago

the naming changed?

aalonsolopez commented 5 months ago

  What are you referring to? 

   On martes, abr 02, 2024 at 4:27 p. m., João Almeida ***@***.***> wrote: 

  the naming changed? 
  —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: ***@***.***> 
  ***@***.***": ***@***.***": "EmailMessage","potentialAction": ***@***.***": "ViewAction","target": "https://github.com/Gravitate-Health/focusing-manager/issues/27#issuecomment-2032191780","url": "https://github.com/Gravitate-Health/focusing-manager/issues/27#issuecomment-2032191780","name": "View Issue"},"description": "View this Issue on GitHub","publisher": ***@***.***": "Organization","name": "GitHub","url": "https://github.com"}}]

joofio commented 5 months ago

lens-selector-mvp2_pregnancy-collaps the naming changed? is it pregancy only now? it says mvp2 still?

aalonsolopez commented 5 months ago

All lenses have the mvp2 tag, and the example is just inside the normal pregnancy lens

of course now it works! Thanks. This will be merged into pregnancy?

as we said here :)

aalonsolopez commented 5 months ago

All lenses have the mvp2 tag, and the example is just inside the normal pregnancy lens

of course now it works! Thanks. This will be merged into pregnancy?

as we said here :)

The MVP2 tag will eventually disappear

aalonsolopez commented 4 months ago

I will close this due to it's implemented inside pregnancy lens

Gravitate-Health / focusing-manager

[CLP] Add collapse example to a lens #27