[L] Improving, debugging MVP2 lenses for MVP3

aalonsolopez commented 4 months ago

First draft of AllergyIntollerance lens is in dev for you to try imagen

joofio commented 4 months ago

error


{
  "message": "Bad request",
  "reason": "Missing parameters"
}

POST https://gravitate-health.lst.tfo.upm.es/focusing/focus/?preprocessors=preprocessing-service-manual&lenses=lens-selector-mvp2_allergyintollerance&patientIdentifier=helen-1
content-type: application/json
Accept: application/json
#Accept: text/html

< ./examples/lactose-preproc-karvea.json

aalonsolopez commented 4 months ago

Are you using in the body this structure? example epi in the body like this

{
    "epi": <full ePI JSON>"
}

joofio commented 4 months ago

ofcourse...missing that

aalonsolopez commented 4 months ago

ofcourse...missing that

Everyone has failures, I just win in "finish things" that are in fact are not finished xD

joofio commented 4 months ago

seems ok!

aalonsolopez commented 4 months ago

OKay, I assume that the system for ingredients and contraindications on Interaction Lens should not be checked because one is the System where the Ingredient is registered. The other is the System that says it has an interaction, and will never be equal right?

aalonsolopez commented 4 months ago

With this doubt, Interaction Lens is finished

joofio commented 4 months ago

OKay, I assume that the system for ingredients and contraindications on Interaction Lens should not be checked because one is the System where the Ingredient is registered. The other is the System that says it has an interaction, and will never be equal right?

didnt quite understand...what do you mean?

joofio commented 4 months ago

ah if the code and system should match? yes they do. the system here is like the dictionary where the code is from. is always important.

May i suggest an additional thing to this lens? (interaction) the extension may have: 1.

{
            "url": "http://hl7.eu/fhir/ig/gravitate-health/StructureDefinition/HtmlElementLink",
            "extension": [
              {
                "url": "elementClass",
                "valueString": "contra-indication-hypericum"
              },
              {
                "url": "concept",
                "valueCodeableReference": {
                  "concept": {
                    "coding": [
                      {
                        "code": "XK4IUX8MNB",
                        "system": "https://gsrs.ncats.nih.gov/ginas/app/beta",
                        "display": "Hypericum perforatum L."
                      }
                    ]
                  }
                }
              }
            ]
          },

2.

          {
            "url": "http://hl7.eu/fhir/ig/gravitate-health/StructureDefinition/HtmlElementLink",
            "extension": [
              {
                "url": "elementClass",
                "valueString": "contra-indication-pregnancy"
              },
              {
                "url": "concept",
                "valueCodeableReference": {
                  "reference": {
                    "reference": "ClinicalUseDefinition/contraindication-pregnancy"
                  }
                }
              }
            ]
          },

could we lookup the clinicalusedefinition to check the code there?

the direct one (1) seems ok!

joofio commented 1 month ago

done for improving logic and making the mvp2 lenses work. bugfixing will be handled bug to bug

Gravitate-Health / lens-selector-mvp2

[L] Improving, debugging MVP2 lenses for MVP3 #17