Gravitate-Health / lens-selector-mvp2

Set of lenses for MVP2
Apache License 2.0
0 stars 0 forks source link

Improve lens catalog return values of swagger #7

Closed joofio closed 11 months ago

joofio commented 1 year ago

Do not know if this is the place to add this but feel free to change if needed.

current response for : GET https://fosps.gravitatehealth.eu/focusing/lenses

{
  "lenses": [
    "lens-selector-div_HIV",
    "lens-selector-div_diabetes",
    "lens-selector-div_pregnancy",
    "lens-selector-mvp2_HIV",
    "lens-selector-mvp2_diabetes",
    "lens-selector-mvp2_pregnancy"
  ]
}

I suggest adding at least two more fields for each lens: 1- a small description of what it doest 2- codes taken into account if any.

aalonsolopez commented 1 year ago

I will transfer this issue to the repo that is the responsible of this, but thank you for creating the issue! I will work on it as soon as possible.

aalonsolopez commented 1 year ago

Now that is transfered, @joofio you expect that the JSON that returns the endpoint GET https://fosps.gravitatehealth.eu/focusing/lenseswith all the lenses available bring a short description of what it does and the codes it searches?

joofio commented 1 year ago

thanks for the transfer.

Yes, I think more detail would be important. At least a short description of what it does..

Alejandro Alonso @.***> escreveu no dia sexta, 6/10/2023 à(s) 09:47:

Now that is transfered, @joofio https://github.com/joofio you expect that the JSON that returns the endpoint GET https://fosps.gravitatehealth.eu/focusing/lenseswith all the lenses available bring a short description of what it does and the codes it searches?

— Reply to this email directly, view it on GitHub https://github.com/Gravitate-Health/lens-selector-mvp2/issues/7#issuecomment-1750216826, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMJVUAOMMZ62OLBTAVANJTX57ASZAVCNFSM6AAAAAA5VPDAQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGIYTMOBSGY . You are receiving this because you were mentioned.Message ID: @.***>

aalonsolopez commented 1 year ago

Perfect. Once reworked lenses are confirmed to be OK, then I will make them more understandable :)

10alejospain commented 1 year ago

I sugest to make the "advance info about lenses" in another endpoint so it's not breaking anything working rn

aalonsolopez commented 1 year ago

I sugest to make the "advance info about lenses" in another endpoint so it's not breaking anything working rn

Working on this solution rn

gmej commented 1 year ago

I sugest to make the "advance info about lenses" in another endpoint so it's not breaking anything working rn

totally agree. I would do GET to lenses/info and get the metadata for the lenses instead of the lenses themselves.

gmej commented 11 months ago

Will be done in gravitate-health/29