Gravitate-Health / mvp-issues

Gateway for issues/discussions/comments regarding MVPs development.
0 stars 0 forks source link

[BUG] Correcting summary lens #40

Open joofio opened 2 months ago

joofio commented 2 months ago
  1. correct title and use language for it
  2. try to add html formatting to endpoint
  3. apply logic similar to the others lenses of epi and ips added in the body

EDIT:

  1. Performance
joofio commented 2 months ago

@aalonsolopez corrected the first one on my repo (upstream), can you look at the second and i will take a look at the third

aalonsolopez commented 2 months ago

A question: Adding HTML formatting you mean in the response? For example:

<div>{{summary}}</div>
joofio commented 2 months ago

no, what I meant with the HTML is formatting the output in terms of styling. how it currently looks: image

see the bullets?

aalonsolopez commented 2 months ago

Ah! Of course, I can substitute the markdown bullets to an HTML unordered list

joofio commented 2 months ago

we hope to be more generic. but that would be a good first step. we could also tweak with the prompt.

i suggest first taking on the errors and then this.

aalonsolopez commented 2 months ago

Perfect

aalonsolopez commented 2 months ago

A question. When the Lens fails because the model requested is not found, what is the expected output? Returning an error? Or picking another model "by default" to always have a useful response?

joofio commented 2 months ago

Error A unknown model should not happen in production

aalonsolopez commented 2 months ago

Summary Lens is working rn

joofio commented 1 month ago

Added performance now.

aalonsolopez commented 1 month ago

Today I will start looking how can we cache requests

aalonsolopez commented 1 month ago

Temperature set to 0, Seed set to 1234. For my recent tests, the answers appear to be deterministic (or almost all, if the response varies may be for some changes in the prompt). @joofio give it a try.

joofio commented 1 month ago

it is in dev i assume right?

joofio commented 1 month ago

currently not working in dev.

aalonsolopez commented 1 month ago

at least rn it is working