Graviton-Code-Editor / Graviton-App

🚀 A modern-looking Code Editor
https://graviton.netlify.app
MIT License
1.16k stars 126 forks source link

[issue] Icon issue Building app on MacOS #308

Open jeff-hykin opened 2 years ago

jeff-hykin commented 2 years ago
Screen Shot 2022-03-15 at 10 40 05 AM
Graviton-App on  main [!] via 𝗥 v1.61.0 took 5m 50s 
∫ yarn build_desktop
yarn run v1.22.10
$ jake build_desktop
Starting 'build_desktop'...
[tauri:build] Running `yarn --cwd ../web run build`
$ vite build
vite v2.7.10 building for production...
✓ 224 modules transformed.
dist/assets/inter-greek-400-normal.98f517ea.woff2                7.77 KiB
dist/assets/inter-greek-ext-400-normal.35d593fc.woff2            4.60 KiB
dist/assets/inter-cyrillic-400-normal.a0d3fd1a.woff2             6.02 KiB
dist/assets/inter-cyrillic-ext-400-normal.444c3024.woff2         9.13 KiB
dist/assets/jetbrains-mono-cyrillic-400-normal.1ae57fe2.woff2    4.57 KiB
dist/assets/jetbrains-mono-latin-ext-400-normal.6315c53c.woff2   5.53 KiB
dist/assets/inter-latin-ext-400-normal.62ad1126.woff2            19.98 KiB
dist/assets/inter-latin-400-normal.2069ee22.woff2                16.26 KiB
dist/assets/jetbrains-mono-latin-400-normal.80a5dc9e.woff2       18.74 KiB
dist/assets/jetbrains-mono-all-400-normal.f86807b7.woff          48.79 KiB
dist/assets/inter-all-400-normal.054f12d0.woff                   125.61 KiB
dist/index.html                                                  0.48 KiB
dist/assets/tauri.3ce1bdff.js                                    1.84 KiB / gzip: 0.72 KiB
dist/assets/event-53654ff1.865685ab.js                           4.61 KiB / gzip: 2.01 KiB
dist/assets/event-0ad4d52e.a66a3e4b.js                           0.49 KiB / gzip: 0.23 KiB
dist/assets/index.c3b81bf3.js                                    5.10 KiB / gzip: 1.79 KiB
dist/assets/http.aaf7612f.js                                     7.32 KiB / gzip: 2.67 KiB
dist/assets/window.d32fda88.js                                   0.44 KiB / gzip: 0.28 KiB
dist/assets/window-efc01659.9b8f3ef9.js                          11.54 KiB / gzip: 1.80 KiB
dist/assets/index.d4d478da.js                                    34.61 KiB / gzip: 10.36 KiB
dist/assets/index.9e1fe2a9.js                                    25.86 KiB / gzip: 6.18 KiB
dist/assets/index.fc0c4f1a.css                                   19.46 KiB / gzip: 12.16 KiB
dist/assets/vendor.71c14717.js                                   778.52 KiB / gzip: 258.03 KiB

(!) Some chunks are larger than 500 KiB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/guide/en/#outputmanualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
   Compiling gveditor-core-deno v0.1.0 (/Users/jeffhykin/repos/testing-tauri/Graviton-App/core_deno)
   Compiling graviton v0.1.0 (/Users/jeffhykin/repos/testing-tauri/Graviton-App/desktop/src-tauri)
warning: unused import: `window_shadows::set_shadow`
  --> desktop/src-tauri/src/main.rs:54:5
   |
54 | use window_shadows::set_shadow;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `graviton` (bin "graviton") generated 1 warning
    Finished release [optimized] target(s) in 6m 34s
[tauri:build] Binary stripped, size reduced by 28.76 MB
    Bundling GravitonEditor.app
Error: failed to bundle project

Caused by:
    0: Failed to create app icon
    1: Failed to create app icon
    2: `No matching IconType`
    3: No matching IconType
jake aborted.
Error [ERR_UNHANDLED_ERROR]: Unhandled error. (undefined)
    at Task.emit (events.js:365:17)
    at Task.errorOut (/Users/jeffhykin/repos/testing-tauri/Graviton-App/node_modules/jake/lib/task/task.js:356:10)
    at Immediate._onImmediate (/Users/jeffhykin/repos/testing-tauri/Graviton-App/node_modules/jake/lib/task/task.js:334:24)
    at processImmediate (internal/timers.js:462:21)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

There was a duplicate in the tauri conf, but removing it doesn't change the error

Screen Shot 2022-03-15 at 11 23 54 AM
AndreasPB commented 2 years ago

Hi, I fixed this by adding a icon.icns(the mac supported icon format)

https://github.com/streamchaser/streamchaser/pull/303/commits/fe8cd220a30e1aeb3b23c272ecaf783a7d9f3ebd

marc2332 commented 2 years ago

Hi, I fixed this by adding a icon.icns(the mac supported icon format)

streamchaser/streamchaser@fe8cd22

Yeah yeah, I just wasn't able to get a MacOS VM working so I wasn't able to make sure the icon was properly rendered. I guess I will have to try again