GravityKit / Dashboard-Views

See Views in the WordPress Dashboard
GNU General Public License v2.0
1 stars 0 forks source link

"Go Live" items #18

Closed mrcasual closed 2 months ago

mrcasual commented 3 months ago

This implements #16 and more.

Install the build file or clone the repo and run npm i && composer i && grunt.

To do

'tooltip'           => __( 'When enabled it will only show any View entries after a search is performed.', 'gk-gravityview' ),
                    'article'           => array(
                        'id'  => '5c772fa02c7d3a0cb9320a84',
                        'url' => 'https://docs.gravitykit.com/article/536-how-to-hide-results-and-only-display-them-if-a-search-is-performed',
                    ),

To test

Foundation

View Editor

Various

P.S. When the Dashboard View is open, you can go to the View Editor by pressing Alt/⌥++V+E.

💾 Build file (2faf62c).

mrcasual commented 3 months ago

@zackkatz, please test/review. More work is needed on styles and I hope you can help with that.

zackkatz commented 3 months ago

@mrcasual I'll add issues I find here in the comments.

On saving a pre-existing View that hasn't been saved since enabling Dashboard Views:

  thrown in /Users/zackkatz/Local/dev/app/public/wp-content/plugins/gravityview-dashboard/src/AdminMenu.php on line 128
[27-May-2024 16:44:50 UTC] PHP Fatal error:  Uncaught Error: Call to undefined method GravityKit\GravityView\DashboardViews\AdminMenu::get_menu_position_by_id() in /Users/zackkatz/Local/dev/app/public/wp-content/plugins/gravityview-dashboard/src/AdminMenu.php:128
Stack trace:
#0 /Users/zackkatz/Local/dev/app/public/wp-includes/class-wp-hook.php(324): GravityKit\GravityView\DashboardViews\AdminMenu->add_admin_menu('')
#1 /Users/zackkatz/Local/dev/app/public/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)
#2 /Users/zackkatz/Local/dev/app/public/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#3 /Users/zackkatz/Local/dev/app/public/wp-admin/includes/menu.php(161): do_action('admin_menu', '')
#4 /Users/zackkatz/Local/dev/app/public/wp-admin/menu.php(422): require_once('/Users/zackkatz...')
#5 /Users/zackkatz/Local/dev/app/public/wp-admin/admin.php(158): require('/Users/zackkatz...')
#6 /Users/zackkatz/Local/dev/app/public/wp-admin/post.php(12): require_once('/Users/zackkatz...')
#7 /Users/zackkatz/.composer/vendor/laravel/valet/server.php(250): require('/Users/zackkatz...')
#8 {main}
  thrown in /Users/zackkatz/Local/dev/app/public/wp-content/plugins/gravityview-dashboard/src/AdminMenu.php on line 128

Resolved: https://gravitykit.slack.com/archives/C727B06MB/p1716830269227759

zackkatz commented 3 months ago

@mrcasual I'm having issues with restricting access. This happens even when selecting all roles.

https://www.loom.com/share/b6be0528c69548d5960adfbf743fd3e2

Resolved: https://gravitykit.slack.com/archives/C727B06MB/p1716837388289959

crbdev commented 3 months ago

Getting a critical error when trying to edit entries in a dashboard View

CleanShot 2024-05-30 at 11 14 09

mrcasual commented 3 months ago

@crbdev,

Getting a critical error when trying to edit entries in a dashboard View

Fixed in 0870858. It would help to know the actual error message in the future. You can enable debugging on your site or install this plugin.

rafaehlers commented 3 months ago
mrcasual commented 3 months ago

@rafaehlers,

The Approve Entries (ajax) field is not yet supported

Entry approval works fine for me.

CleanShot 2024-06-03 at 22 07 00@2x

zackkatz commented 3 months ago

Approve Entries works for me as well using all layouts (Table, List, DataTables, DIY) @rafaehlers . What layout were you using?

crbdev commented 3 months ago

When adding a "Gravity Forms" widget to a View, the form does not render in the dashboard.

Entry approval worked for me, too.