Update `develop` with possibly missing bugfixes

GravityKit / GravityExport-Lite

GravityExport Lite. Export all Gravity Forms entries to Excel (.xlsx) via a secret (shareable) url.

https://gfexcel.com

GNU General Public License v2.0

12 stars 8 forks source link

Update `develop` with possibly missing bugfixes #151

Closed doekenorg closed 1 year ago

doekenorg commented 1 year ago

Since develop (v2) was built some time ago; there are probably a bunch of issues fixed on master that should be backported.

We need to go through these and keep a list on this issue.

[x] Add missing translations (on new language slug?)
[x] Javascript no longer works for GravityExport (Filters)
[x] Migration is run too late, need to fix with transient /option check
[x] CSS for sorting is not working out due to gravity forms using grid, while we use flex. Rewrite to grid?

doekenorg commented 1 year ago

~~When #156 is merged all is resolved.~~

Or not. Found another bug.

[x] Download counter not migrated to v2

rafaehlers commented 1 year ago

@doekenorg I tested v2 and the download counter is working:

doekenorg commented 1 year ago

@rafaehlers did you also test if the migrations work? This needs an old installation with a download link set up. Then upgrade the plugin. After that the download link should still work; and the settings should all be still there, but in the new design (best way to check everything works :-) )

rafaehlers commented 1 year ago

I remember the migration thing, everything worked as expected, but the download URL didn't work. I had to regenerate that.

doekenorg commented 1 year ago

Hmm; that's unfortunate. Was almost the first thing I ported over :S People have these download URL's. They should really work.

[x] Fix Migration of download URL