search

GravityKit / GravityExport-Lite

GravityExport Lite. Export all Gravity Forms entries to Excel (.xlsx) via a secret (shareable) url.
https://gfexcel.com
GNU General Public License v2.0
12 stars 8 forks source link

Add all settings to Foundation if Foundation exists #154

Open zackkatz opened 1 year ago

zackkatz commented 1 year ago

If Foundation exists, the settings should be in a GravityExport tab (not a separate GravityExport Lite tab).

We need to think about where the setting would be saved (in the prior setting key or in Foundation settings…)

doekenorg commented 1 year ago

@zackkatz You say

If Foundation exists

But that's on us, right? Wouldn't Foundation be included in the next major? Or is that not shipped with the plugin?

If it is, I think we should port the settings to Foundation for consistency. If it isn't; then we should keep it on the plugin, to avoid having multiple places.

zackkatz commented 1 year ago

We haven't prepared Foundation for .org. It will take some amount of work to make it compliant. @doekenorg

doekenorg commented 1 year ago

Right, so In that case; I guess we could check for Foundation; and duplicate the settings over there; whilst saving them to the plugin for BC.

mrcasual commented 1 year ago

Another option is to integrate Foundation but disable products/licensing if it's just GravityExport Lite that's using it.

doekenorg commented 1 year ago

Another option is to integrate Foundation but disable products/licensing if it's just GravityExport Lite that's using it.

I like this option best TBH. Since we are moving to 2.0, this is the best time to introduce a new settings page + location where the settings are stored.

zackkatz commented 1 year ago

@mrcasual we would need opt-in metrics reporting and Beacon