Closed doekenorg closed 1 year ago
@doekenorg do I need to test something here, or do you just need a code review?
@doekenorg do I need to test something here, or do you just need a code review?
Both if possible. The thing to test would be if settings are properly ported from 1.* to this new version. In this version the plugin is a feed plugin, and not a regular plugin anymore. Therefore all the current settings should be moved towards this new addon without breaking the download url.
static $version
and viais_subclass_of
, to prevent instantiating of unused migrations.init_admin
to ensure the front-end wil not trigger a migration. This also removes the issue of updating the plugin by hand instead of the normal update process.GravityExportAddon::error_log
. Did this so we can later simply update this method to call the Foundation logger.