GravityLabs / goose

Html Content / Article Extractor in Scala - open sourced from Gravity Labs
http://gravity.com
Apache License 2.0
1.53k stars 322 forks source link

Why not SBT? #91

Open anderssonfilip opened 10 years ago

anderssonfilip commented 10 years ago

I understand this was ported from Java to Scala but why wasn't the maven file converted to sbt?

One of the first thing Scala programmers learn is sbt and if you are coming from another language C#, C++ etc there is a chance you've never used(or heard of maven) as build tool

lino commented 10 years ago

You've got to use something. Every build tool has advantages and disadvantages. Many shops use maven all over the place because they have a working CI set up for maven projects.

lino commented 10 years ago

What I wanted to say was: Changing the build tool will scare away our countless contributors. For real: Changing the build system will eventually lead to the first new commit since 2012, so that's a major point for doing it. :laughing: Maybe I'll contribute something as well, it's a good project after all.

anderssonfilip commented 10 years ago

Hi Lino, thanks for replying. I might just submit a pull request with a build.sbt file. Just found about this project today and looking into using it. Also noticed there hasn't been any commits for a while

lino commented 10 years ago

Oh, there already is a PR for this. #79

lino commented 10 years ago

Actually a look at the network graph https://github.com/GravityLabs/goose/network reveals that there are many contributions although there is no real project maintenance happening anymore. Maybe it's time to fork the project and merge the reasonable PRs and other improvements. But who has time for that.

anderssonfilip commented 10 years ago

There is also a full sbt definition in this fork https://github.com/jaytaylor/goose-ng/commit/496adef0a635216874ac95438d606ce66eaadddc

warrd commented 9 years ago

Got Goose up and running with sbt and Scala 2.11.2 at warrd/goose-fork@c256c403. Let me know if you want to bring the changes into the original repo, and I will put in a pull request .