search

GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
88 stars 21 forks source link

mPDF: Cannot upload font "Great Vibes" via Font Manager #1304

Closed jakejackson1 closed 1 year ago

jakejackson1 commented 2 years ago

Description When trying to install https://fonts.google.com/specimen/Great+Vibes using the Font Manager mPDF creates a bunch of PHP notices while checking if the font is OTF-compatible and it fails to be installed (although is uploaded).

Step To Reproduce Steps to reproduce the behavior:

  1. Go to the Font Manager
  2. Add a new font
  3. Upload Great Vibes TTF file to the Regular section
  4. Save

Expected behavior The font successfully uploads and saved

Additional context Testing shows the PHP process just stops during OTF processing. Further debugging will need to be done to determine why.

KratosGemini commented 2 years ago

I'm also getting an error for Noto Sans. I wonder if it's the same issue. https://fonts.google.com/noto/specimen/Noto+Sans

jakejackson1 commented 1 year ago

Also a problem with Poppins https://fonts.google.com/specimen/Poppins

jakejackson1 commented 1 year ago

Have opened a PR upstream to fix the problem installing Great Vibes, Noto Sans, and Poppins. Once merged, we'll cut a new release with the fix.

jakejackson1 commented 1 year ago

This specific issue has been fixed in Gravity PDF 6.5.1. Note, there is a different issue that does affect some font variants (from this list: Noto Sans Bold) and we've opened another issue about it on GitHub: https://github.com/GravityPDF/gravity-pdf/issues/1429