jakejackson1 commented 2 years ago

Description

Resolves attributes being decoded unexpectedly when using a tag like <tocpagebreak toc-posthtml="<p>Comments after the Contents table</p>"> inside the Core template HTML.

Testing instructions

Screenshots

Checklist:

[x] I've tested the code.
[ ] My code is easy to read, follow, and understand
[ ] My code follows the accessibility standards.
[ ] My code has proper inline documentation / docblocks.

Additional Comments

codecov[bot] commented 2 years ago

Codecov Report

Merging #1393 (d396fdc) into development (90cbaac) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d396fdc differs from pull request most recent head a836d83. Consider uploading reports for the commit a836d83 to get more accurate results

@@             Coverage Diff              @@
##           development    #1393   +/-   ##
============================================
  Coverage        93.30%   93.30%           
============================================
  Files               57       57           
  Lines             1464     1464           
  Branches           370      370           
============================================
  Hits              1366     1366           
  Misses              90       90           
  Partials             8        8

Help us with your feedback. Take ten seconds to tell us how you rate us.

jakejackson1 commented 1 year ago

@jestonihpi could you review this PR and check that Core PDF templates don't have any display problems when using Drag and Drop columns? Check using a variety of field types and various HTML mark-up please.

GravityPDF / gravity-pdf