jakejackson1 commented 2 years ago

Description

Resolves escaping issue when using a Windows-based local path in images.

esc_url() will completely remove a Windows-based local path and the PDF will show an image-not-found icon.

Testing instructions

On a Windows machine with a local development environment (not containered), add a signature field to your form, fill out the form, and view the PDF. Prior to this update the signature wouldn't show. After the update it does.

Screenshots

Checklist:

[x] I've tested the code.
[ ] My code is easy to read, follow, and understand
[ ] My code follows the accessibility standards.
[ ] My code has proper inline documentation / docblocks.

Additional Comments

codecov[bot] commented 2 years ago

Codecov Report

Merging #1397 (62192d2) into development (b2bf721) will not change coverage. The diff coverage is 40.00%.

:exclamation: Current head 62192d2 differs from pull request most recent head b4a255c. Consider uploading reports for the commit b4a255c to get more accurate results

@@              Coverage Diff               @@
##             development    #1397   +/-   ##
==============================================
  Coverage          77.29%   77.29%           
- Complexity          2893     2895    +2     
==============================================
  Files                243      243           
  Lines              10095    10095           
  Branches             370      370           
==============================================
  Hits                7803     7803           
  Misses              2284     2284           
  Partials               8        8

Impacted Files	Coverage Δ
src/Helper/Fields/Field_Signature.php	`64.86% <0.00%> (ø)`
src/Helper/Fields/Field_Slim.php	`0.00% <0.00%> (ø)`
src/Helper/Fields/Field_Slim_Post.php	`0.00% <0.00%> (ø)`
src/Helper/Fields/Field_Post_Image.php	`97.77% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.