jakejackson1 commented 1 year ago

Description

When the Gravity Wiz eCommerce add-on is installed and activated, this PR will:

Resolves a HTML encoding issue in the Coupon field Label (Gravity Forms Coupon add-on) when displaying in the product table.
Removes the coupon from the product line items
Resolves a PHP Notice when checking the coupon field type due to the $field_id containing both the ID and code, separated by a | character.

Testing instructions

Install the Gravity Wiz e-Commerce Perk
Install the Gravity Forms Coupon add-on
Create a form with a Product field, Option field, Subtotal field, Tax Field, Discount Field, and Coupon Field
Go to Forms -> Coupons and setup a coupon code for this new form
Submit a test entry with the product and options purchased. Apply the coupon code.
Setup a Core PDF on the form and view the results of that test entry

The PDF should correctly generate a Product table that matches what is shown on the Entry Details page.

Screenshots

Screen Shot 2022-08-08 at 2 20 14 pm

Checklist:

[x] I've tested the code.
[ ] My code is easy to read, follow, and understand
[ ] My code follows the accessibility standards.
[ ] My code has proper inline documentation / docblocks.

Additional Comments

codecov[bot] commented 1 year ago

Codecov Report

Merging #1400 (49a1b66) into development (d35f361) will increase coverage by 0.00%. The diff coverage is 75.00%.

@@              Coverage Diff               @@
##             development    #1400   +/-   ##
==============================================
  Coverage          77.32%   77.32%           
  Complexity          2896     2896           
==============================================
  Files                243      243           
  Lines              10096    10097    +1     
  Branches             370      370           
==============================================
+ Hits                7807     7808    +1     
  Misses              2281     2281           
  Partials               8        8

Impacted Files	Coverage Δ
src/Helper/Fields/Field_Products.php	`84.48% <75.00%> (+0.13%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.