GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
88 stars 21 forks source link

Add filterable class to PDF links on Entry List and Details Pages #1420

Closed jakejackson1 closed 1 year ago

jakejackson1 commented 1 year ago

Description

Also include the type of PDF link it is as a data attribute (view or download). These changes are necessary for the upcoming Enhanced Download add-on.

Testing instructions

The E2E tests will catch any issues.

Screenshots

Checklist:

Additional Comments

codecov[bot] commented 1 year ago

Codecov Report

Merging #1420 (3d525e7) into development (6da40d2) will increase coverage by 17.70%. The diff coverage is n/a.

:exclamation: Current head 3d525e7 differs from pull request most recent head 0c1e1ae. Consider uploading reports for the commit 0c1e1ae to get more accurate results

@@                Coverage Diff                 @@
##             development    #1420       +/-   ##
==================================================
+ Coverage          75.60%   93.30%   +17.70%     
==================================================
  Files                186       57      -129     
  Lines               8718     1464     -7254     
  Branches               0      370      +370     
==================================================
- Hits                6591     1366     -5225     
+ Misses              2127       90     -2037     
- Partials               0        8        +8     
Impacted Files Coverage Δ
src/Model/Model_PDF.php
src/View/html/PDF/entry_detailed_pdf.php
src/View/html/PDF/entry_list_pdf_multiple.php
src/View/html/PDF/entry_list_pdf_single.php
src/Helper/Fields/Field_Option.php
src/Controller/Controller_System_Report.php
src/Helper/Fields/Field_Checkbox.php
src/Helper/Helper_Misc.php
src/View/html/GravityForms/settings_field.php
src/Helper/Fields/Field_V3_Products.php
... and 233 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.