jestonihpi commented 1 year ago

Description

This PR registers two new choices in the conditional logic selector:

Payment Status
Payment Amount

I've opted not to include additional entry meta like Entry ID, or Entry Date, at this stage as it requires additional work to support. This PR just focuses on the most important meta data.

TODO:

[x] Check if conditional logic will pass as is, or if we need to hook into Gravity Forms and make some tweaks when the logic is being parsed
[ ] Write E2E test

Partially resolves #1404

Testing instructions

Screenshots

Checklist:

[x] I've tested the code.
[x] My code is easy to read, follow, and understand
[x] My code follows the accessibility standards.
[ ] My code has proper inline documentation / docblocks.

Additional Comments

codecov[bot] commented 1 year ago

Codecov Report

Merging #1424 (a5bbad1) into development (891ce43) will increase coverage by 15.19%. The diff coverage is n/a.

:exclamation: Current head a5bbad1 differs from pull request most recent head 2295d5c. Consider uploading reports for the commit 2295d5c to get more accurate results

@@                Coverage Diff                 @@
##             development    #1424       +/-   ##
==================================================
+ Coverage          78.11%   93.30%   +15.19%     
==================================================
  Files                243       57      -186     
  Lines              10188     1464     -8724     
  Branches             370      370               
==================================================
- Hits                7958     1366     -6592     
+ Misses              2222       90     -2132     
  Partials               8        8

Impacted Files	Coverage Δ
src/Model/Model_Form_Settings.php
src/bootstrap.php
src/Helper/Fields/Field_Date.php
src/Helper/Helper_Url_Signer.php
src/Helper/Fields/Field_Address.php
src/Helper/Helper_Templates.php
src/Helper/Licensing/EDD_SL_Plugin_Updater.php
src/Helper/Fields/Field_Quantity.php
src/Helper/Fonts/TtfFontValidation.php
src/Controller/Controller_Activation.php
... and 176 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jestonihpi commented 1 year ago

History :

Jake : @jestonihpi looks like Gravity Wiz strikes again! They have done something similar with their snippets: https://github.com/gravitywiz/snippet-library/blob/master/gravity-forms/gw-conditional-logic-entry-meta.php#L165-L179. Note: there's currently no license included with this snippet, so use it as a reference for how you hook into Gravity Forms to add custom conditional logic.

jakejackson1 commented 5 months ago

Closing in favour of https://github.com/GravityPDF/gravity-pdf/pull/1501

GravityPDF / gravity-pdf