GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
88 stars 21 forks source link

Resolve PHP8.1 unit test issues #1437

Closed jakejackson1 closed 1 year ago

jakejackson1 commented 1 year ago

Description

In testing, running phpunit --group ajax on its own worked without any changes to the codebase. It was only when running the standard suite and the AJAX tests at the same time that caused issues. I wasn't able to track down the cause in the limited time I spent investigating. Instead, have reverted to excluding AJAX tests by default and running them separately in the GitHub Actions.

Testing instructions

All unit tests should pass.

Screenshots

Checklist:

Additional Comments

codecov[bot] commented 1 year ago

Codecov Report

Merging #1437 (a9f4739) into development (d34590c) will decrease coverage by 17.30%. The diff coverage is n/a.

:exclamation: Current head a9f4739 differs from pull request most recent head a40077d. Consider uploading reports for the commit a40077d to get more accurate results

@@                Coverage Diff                 @@
##             development    #1437       +/-   ##
==================================================
- Coverage          93.30%   75.99%   -17.31%     
- Complexity             0     2943     +2943     
==================================================
  Files                 57      243      +186     
  Lines               1464    10129     +8665     
  Branches             370      370               
==================================================
+ Hits                1366     7698     +6332     
- Misses                90     2423     +2333     
  Partials               8        8               
Impacted Files Coverage Δ
src/Helper/Fields/Field_Product.php 100.00% <0.00%> (ø)
src/Helper/Fields/Field_V3_Section.php 0.00% <0.00%> (ø)
src/View/html/FormSettings/add_edit.php 90.47% <0.00%> (ø)
src/Controller/Controller_Save_Core_Fonts.php 17.77% <0.00%> (ø)
src/View/html/PDF/form_title.php 66.66% <0.00%> (ø)
src/Helper/Fields/Field_Address.php 86.00% <0.00%> (ø)
src/View/html/PDF/core_template_styles.php 98.03% <0.00%> (ø)
src/Helper/Helper_Abstract_Config_Settings.php 83.33% <0.00%> (ø)
src/Helper/Fields/Field_Shipping.php 92.30% <0.00%> (ø)
src/Helper/Fonts/FlushCache.php 83.33% <0.00%> (ø)
... and 176 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.