GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
88 stars 21 forks source link

Move Core Font Installer Notice to selected pages. #1445

Closed jestonihpi closed 2 months ago

jestonihpi commented 1 year ago

Description

WIP. I have only set the Core Font Installer Notice exclusively to Gravity PDF pages. I need to add this to these pages as well:

  1. Form List
  2. Form Settings
  3. Form Entry List
  4. Form Entry Details

1439

Testing instructions

Screenshots

Checklist:

Additional Comments

codecov[bot] commented 1 year ago

Codecov Report

Merging #1445 (c8bdf64) into development (f9649f0) will increase coverage by 17.58%. The diff coverage is n/a.

:exclamation: Current head c8bdf64 differs from pull request most recent head 172cd15. Consider uploading reports for the commit 172cd15 to get more accurate results

@@                Coverage Diff                 @@
##             development    #1445       +/-   ##
==================================================
+ Coverage          75.71%   93.30%   +17.58%     
==================================================
  Files                243       57      -186     
  Lines              12828     1464    -11364     
  Branches             370      370               
==================================================
- Hits                9713     1366     -8347     
+ Misses              3107       90     -3017     
  Partials               8        8               
Impacted Files Coverage Δ
src/Controller/Controller_Actions.php
src/Helper/Fields/Field_Consent.php
src/Helper/Fields/Field_Post_Category.php
src/View/html/Settings/licence.php
src/Controller/Controller_Custom_Fonts.php
src/Helper/Helper_Interface_Url_Signer.php
src/deprecated.php
src/Helper/Helper_Field_Container.php
src/Helper/Fields/Field_Shipping.php
src/Helper/Helper_Abstract_Field_Products.php
... and 176 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jestonihpi commented 1 year ago

Hi @jakejackson1, can you review the recent changes on this PR please?

This would look like on Form list: image The font will be reset to adapt to the current error messages.

But when its on Gravity PDF pages, it will look like this: image

Not sure if this is a good compromise, please advise.

Thanks!

jakejackson1 commented 2 months ago

Resolved in https://github.com/GravityPDF/gravity-pdf/pull/1549