Closed jestonihpi closed 4 weeks ago
Attention: Patch coverage is 77.92208%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 76.03%. Comparing base (
32c45cc
) to head (262c5e3
). Report is 1 commits behind head on development.
Files | Patch % | Lines |
---|---|---|
src/Statics/Queue_Callbacks.php | 11.11% | 8 Missing :warning: |
src/Model/Model_PDF.php | 79.16% | 5 Missing :warning: |
src/Controller/Controller_Pdf_Queue.php | 90.90% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jakejackson1 , can you take peek at this PR when you're available. I tried working on the approach you've mentioned on the initial meeting. I was unable work my way around it.
Not sure how to properly set the unit test for this 🤔
Prior to Gravity Form 2.6.9 release which introduced this new filter
gform_is_asynchronous_notifications_enabled
. We need to check its value when getting the queued task on form. If this is set to true we need to disable queued PDFs and notifications as well.Missing Unit Test
Description
Controller_Pdf_Queue class get_queuet_tasks method : get the value of the filter
gform_is_asynchronous_notifications_enabled
return $queue_data asap if itstrue
1444
Testing instructions
Screenshots
Checklist:
Additional Comments