GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
89 stars 21 forks source link

Correctly sanitize the conditional logic setting #1454

Closed jakejackson1 closed 1 year ago

jakejackson1 commented 1 year ago

Description

The conditional logic JSON was being passed through sanitize_text_field(), instead of \GFFormsModel::sanitize_conditional_logic(). This update ensures the JSON data is correctly decoded, sanitized, and then recoded.

Testing instructions

Let automated tests run.

Screenshots

Checklist:

Additional Comments

codecov[bot] commented 1 year ago

Codecov Report

Merging #1454 (c222ee0) into development (f9649f0) will increase coverage by 17.58%. The diff coverage is n/a.

:exclamation: Current head c222ee0 differs from pull request most recent head b6fa1d8. Consider uploading reports for the commit b6fa1d8 to get more accurate results

@@                Coverage Diff                 @@
##             development    #1454       +/-   ##
==================================================
+ Coverage          75.71%   93.30%   +17.58%     
==================================================
  Files                243       57      -186     
  Lines              12828     1464    -11364     
  Branches             370      370               
==================================================
- Hits                9713     1366     -8347     
+ Misses              3107       90     -3017     
  Partials               8        8               

see 186 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.