GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
88 stars 21 forks source link

Always deactivate license key after AJAX request #1468

Closed jakejackson1 closed 1 year ago

jakejackson1 commented 1 year ago

Description

Regardless of the outcome of the API request, always remove the license key from the database. This prevents UX issues if a license is manually deactivated from the GravityPDF.com account.

Update the error message to let a user know the license may not have been deactivated successfully, with a link to their account.

Resolves #1432

Checklist:

Additional Comments

codecov[bot] commented 1 year ago

Codecov Report

Merging #1468 (85a0e84) into development (4d79680) will increase coverage by 17.54%. The diff coverage is n/a.

:exclamation: Current head 85a0e84 differs from pull request most recent head 13db133. Consider uploading reports for the commit 13db133 to get more accurate results

@@                Coverage Diff                 @@
##             development    #1468       +/-   ##
==================================================
+ Coverage          75.75%   93.30%   +17.54%     
==================================================
  Files                243       57      -186     
  Lines              12842     1464    -11378     
  Branches             370      370               
==================================================
- Hits                9729     1366     -8363     
+ Misses              3105       90     -3015     
  Partials               8        8               

see 186 files with indirect coverage changes