GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
89 stars 21 forks source link

Fix fatal error using GF Google Analytics Pagination feature #1479

Closed jakejackson1 closed 7 months ago

jakejackson1 commented 7 months ago

Description

Use the passed $form and $entry object when processing, as $entry may be created before submission and $gform->get_entry() will return a WP_Error in this instance. This is the case when using the Pagination feature in the GF Google Analytics plugin.

Checklist:

Additional Comments

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0889cdd) 75.13% compared to head (e4479e8) 93.30%.

:exclamation: Current head e4479e8 differs from pull request most recent head 74b7254. Consider uploading reports for the commit 74b7254 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #1479 +/- ## ================================================== + Coverage 75.13% 93.30% +18.16% ================================================== Files 243 57 -186 Lines 12880 1464 -11416 Branches 370 370 ================================================== - Hits 9678 1366 -8312 + Misses 3194 90 -3104 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.