GravityPDF / gravity-pdf

Gravity PDF is a GPLv2-licensed WordPress plugin that allows you to automatically generate, email and download PDF documents using Gravity Forms.
https://gravitypdf.com
89 stars 21 forks source link

Remove type hinting in Controller_Export_Entries #1486

Closed jakejackson1 closed 6 months ago

jakejackson1 commented 6 months ago

Description

The methods are used by filters/hooks, and any plugin can change the property type. Remove the type hints to stop PHP fatal errors occurring if a different property type is passed. Instead, we'll do additional checks on these properties to see if the data required is present.

Resolves https://github.com/GravityPDF/pdf-for-gravityview/issues/30

Checklist:

Additional Comments

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f90b279) 93.30% compared to head (d48bcdc) 75.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #1486 +/- ## ================================================== - Coverage 93.30% 75.13% -18.18% - Complexity 0 2953 +2953 ================================================== Files 57 243 +186 Lines 1464 12882 +11418 Branches 370 370 ================================================== + Hits 1366 9679 +8313 - Misses 90 3195 +3105 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.