GravityPDF / gravity-pdf

Gravity PDF is the ultimate third-party PDF automation tool for generating digital PDFs using the popular form-builder plugin Gravity Forms.
https://gravitypdf.com
89 stars 20 forks source link

Limit admin pages notices are displayed on #1549

Closed jakejackson1 closed 4 months ago

jakejackson1 commented 4 months ago

Description

Improve handling of admin notices so they aren't so intrusive, and more contextual.

Changes include:

  1. Notices are limited to Gravity PDF pages, Gravity Forms Form List, Entry and Settings pages, plus the WP Dashboard and Plugins page
  2. If a startup error exists, only users with the activate_plugins capability will be able to view the specifics
  3. If a startup error exists and a user doesn't have the correct capability, a generic error will be shown
  4. Undo the integration with Gravity Forms notice system, and trick it into thinking standard WordPress notices are relevant

Checklist:

Additional Comments

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.02%. Comparing base (f523b0a) to head (91f195c). Report is 1 commits behind head on development.

Files Patch % Lines
src/Helper/Helper_Notices.php 55.55% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #1549 +/- ## =============================================== - Coverage 76.09% 76.02% -0.07% =============================================== Files 248 248 Lines 12983 12990 +7 Branches 370 370 =============================================== - Hits 9879 9876 -3 - Misses 3096 3106 +10 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.