GravityPDF / gravity-pdf

Gravity PDF is the ultimate third-party PDF automation tool for generating digital PDFs using the popular form-builder plugin Gravity Forms.
https://gravitypdf.com
89 stars 20 forks source link

Fix Notification bug during PDF Background Processing #1555

Closed jakejackson1 closed 4 months ago

jakejackson1 commented 4 months ago

Description

A bug was introduced in 6.11 that skipped the enabled notification checks when using PDF Background Processing. This update reintroduces these checks to verify a notification is active and any conditional logic passes.

Fixes #1554

Testing instructions

  1. Enable PDF Background processing in global PDF settings
  2. Setup two Notifications on a form and set one to inactive
  3. Configure PDF on the form and attach the PDF to both notifications
  4. Submit the form
  5. Verify only one notification email is sent

Checklist:

Additional Comments

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.07%. Comparing base (bc81f06) to head (73750a2). Report is 2 commits behind head on development.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #1555 +/- ## =============================================== + Coverage 76.02% 76.07% +0.05% =============================================== Files 248 248 Lines 12989 12993 +4 Branches 370 370 =============================================== + Hits 9875 9885 +10 + Misses 3106 3100 -6 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.