GravityPDF / gravity-pdf

Gravity PDF is the ultimate third-party PDF automation tool for generating digital PDFs using the popular form-builder plugin Gravity Forms.
https://gravitypdf.com
89 stars 20 forks source link

Update Node and WP versions #1585

Open jakejackson1 opened 1 month ago

jakejackson1 commented 1 month ago

Description

WIP to upgrade the JS dependencies.

Testing instructions

Screenshots

Checklist:

Additional Comments

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.46002% with 99 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (fb70e5c) to head (6b1908f). Report is 7 commits behind head on hot-patch.

Files with missing lines Patch % Lines
...s/js/react/components/FontManager/FontListItems.js 87.03% 13 Missing and 1 partial :warning:
src/assets/js/react/reducers/fontManagerReducer.js 89.38% 12 Missing :warning:
...eact/components/FontManager/AddUpdateFontFooter.js 85.48% 9 Missing :warning:
...js/react/components/FontManager/FontManagerBody.js 94.93% 8 Missing :warning:
...ct/components/Template/TemplateHeaderNavigation.js 80.00% 8 Missing :warning:
...ets/js/react/components/FontManager/FontVariant.js 78.12% 7 Missing :warning:
src/assets/js/react/components/ShowMessage.js 80.55% 6 Missing and 1 partial :warning:
...ets/js/react/components/FontManager/FontManager.js 76.19% 4 Missing and 1 partial :warning:
.../js/react/components/Template/TemplateContainer.js 73.68% 4 Missing and 1 partial :warning:
src/assets/js/react/sagas/fontManager.js 92.30% 4 Missing :warning:
... and 12 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## hot-patch #1585 +/- ## ============================================== + Coverage 75.68% 92.72% +17.04% ============================================== Files 251 58 -193 Lines 13612 1526 -12086 Branches 370 420 +50 ============================================== - Hits 10302 1415 -8887 + Misses 3302 103 -3199 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kielllll commented 1 month ago

image

kielllll commented 3 weeks ago

After the updates, found 25 failed tests on e2e

image
jakejackson1 commented 2 weeks ago
  1. Remove deprecated babel proposal packages (done)
  2. Move from standard to wp scripts (WIP)
  3. Remove unused api call
  4. Update doc blocks
  5. Remove React PropType from production build https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types
jakejackson1 commented 1 week ago

Issues:

  1. superagent to fetch transition: throw exception if ! response.ok
  2. AJAX responses: wp_die() cannot set status code if content already output