Psuedo-class selector :text producing errors and incorrect results - Githubissues

GravityPDF / querypath

A fork of QueryPath: a PHP library for HTML(5)/XML querying (CSS 4 or XPath) and processing (like jQuery) with PHP8.3 support

Other

21 stars 2 forks source link

Psuedo-class selector :text producing errors and incorrect results #50

Open jakejackson1 opened 3 months ago

jakejackson1 commented 3 months ago

Pull Request type

Please check the type of change your PR introduces:

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

If doing ->is(':text') on a text node an error is produced.
If doing ->find(':text') it won't match <input /> tags without a type (which are considered text inputs). See https://api.jquery.com/text-selector/

Issue Number: https://github.com/GravityPDF/querypath/issues/49

What is the new behavior?

TBA

Does this introduce a breaking change?

[ ] Yes
[ ] No

TBA

Other information

Unit tests are written. Code to pass the tests still to be written.