search

GravityProject / gravity

Open source social network built with Meteor
MIT License
131 stars 62 forks source link

Code Cleanup #107

Closed mattvella07 closed 8 years ago

mattvella07 commented 8 years ago

Cleaned up the code based on messages from linter, and updated eslintrc file to comment out rules (no-dupe-class-members, prefer-arrow-callback, prefer-template) that are not supported by this version of the linter. The version of the linter we use is based on eslint 1.1, and the previously mentioned rules are supported by eslint 1.2.

zaverichintan commented 8 years ago

Will there be any major changes the to the settings?

mattvella07 commented 8 years ago

Nope, just removed the settings that our version of the linter doesn't support so you will see less warnings when running meteor command.

zaverichintan commented 8 years ago

Are we planning to upgrade our linter? If yes, then we might have to change the settings

mattvella07 commented 8 years ago

We are using the latest version of the linter meteor package but it is based on a previous version of the linter NPM package. So we can't upgrade right now.

pmuens commented 8 years ago

Great! Thank you guys!