GraxCode / zelixkiller

Deobfuscate ZKM up to version 11, replaced by threadtear
GNU General Public License v3.0
67 stars 20 forks source link

The project doesn't work. #4

Closed Levelheader closed 6 years ago

Levelheader commented 6 years ago

I tried creating an instance of this project in eclipse, using the utilities needed, aside from ASM. The only utility that was close to working was the asm-all-6.0_BETA. There are some big problems though, like MethodNode owner not being accessible as well as ConstantValue subtype errors.

GraxCode commented 6 years ago

I'm using a modified version of asm by lpk that I will add to this repo soon, but can you give more details on those ConstantValue errors?

GenericException commented 6 years ago

modified version of asm by lpk

You ought to re-engineer your code to not depend on bad-code I wrote a few years ago. I've seen it be used a lot by people who probably are thinking exactly what I thought back then.

"Why does MethodNode/FieldNode not have a simple way to find their defining ClassNode?"

Well, because that would be an anti-pattern. Its clearly supposed to be hierarchy based, IE:

Sure having an field reference is handy but it breaks this hierarchy and enables bad design since "its just faster this way". Making something extensible and easily reusable should be a top priority over getting something finished quickly. It'll only come back to haunt you and your users later.

You're making good stuff, it just pains me to see my bad practices being repeated by others.

GraxCode commented 6 years ago

Well, as long as it works I'm fine with it

Levelheader commented 5 years ago

Lol you're both great coders keep up the spirit.