Unexpand: Initial implementation

GrayJack / coreutils

Core utils re-implementation for UNIX/UNIX-like systems written in Rust

Mozilla Public License 2.0

108 stars 40 forks source link

Unexpand: Initial implementation #102

Closed bojan88 closed 5 years ago

bojan88 commented 5 years ago

Implementation for https://github.com/GrayJack/coreutils/issues/7

bojan88 commented 5 years ago

@GrayJack thanks for the quick review. I appreciate it, especially the error handling parts. I hope I addressed all your suggestions/requests. Can you please review it again?

GrayJack commented 5 years ago

Looks fine for me :smile:

The test grow big, so I would recommend create a module just for tests, give a look at the wc and cut, that's the way I did it the tests module

bojan88 commented 5 years ago

@GrayJack I moved the tests to a separate module, but in the same file. Hope that's fine...

GrayJack commented 5 years ago

It's great!! Thanks for the contribution