search

GrayJack / coreutils

Core utils re-implementation for UNIX/UNIX-like systems written in Rust
Mozilla Public License 2.0
106 stars 40 forks source link

Fix cargo deny error #139

Closed jeremyvii closed 3 years ago

jeremyvii commented 3 years ago

This PR attempts to fix the cargo deny error in the Github actions.

GrayJack commented 3 years ago

As far as I remember the time crate removed getting the local UTC offset from UNIX systems due the C API used was thread unsafe when the type used was marked to be thread safe. That means that the methods used by those types now either returns always Err or always None on UNIX since 0.2.23, that's the reason I fixed the version to 0.2.22 since until now all tools are single threaded. Does this problem been solved?

jeremyvii commented 3 years ago

Ah, I was not aware of that issue. I mistakenly assumed that if the tests passed it was working, and that this fix was as easy as upgrading an outdated crate. I am not familiar with the C API to propose anything else regarding this, so I will go ahead and close this PR.