GrayJack / coreutils

Core utils re-implementation for UNIX/UNIX-like systems written in Rust
Mozilla Public License 2.0
106 stars 40 forks source link

Time: More cleanup #155

Closed envp closed 2 years ago

envp commented 2 years ago

@GrayJack Do you think we can use StringEscapeDecoder somewhere else in this project?

GrayJack commented 2 years ago

Do you think we can use StringEscapeDecoder somewhere else in this project?

Maybe printf? I'm not sure at the top of my head

About the CI failures, it is a crate that updated patch version using new rust features. I'll push a dirt fix soon, I let you know so you can rebase your branch

GrayJack commented 2 years ago

@envp Can you rebase your branch from current dev branch?

envp commented 2 years ago

Do you think we can use StringEscapeDecoder somewhere else in this project?

Maybe printf? I'm not sure at the top of my head

Looked at printf looks like it also does some string unescaping. Also there's a possible bug, \v is mapped to \x0D (which is \r) but its supposed to be \x0B reference

Will rebase, and refactor it into coreutils core.

bors[bot] commented 2 years ago

Build succeeded: