search

GrayJack / coreutils

Core utils re-implementation for UNIX/UNIX-like systems written in Rust
Mozilla Public License 2.0
106 stars 40 forks source link

Du: Implement du #97

Closed KaindlJulian closed 4 years ago

KaindlJulian commented 4 years ago

Implement du #23

References:

Missing flags

KaindlJulian commented 4 years ago

Sry was a bit busy today. I fixed everything you mentioned. I also noticed that I forgot the --total flag. Will take care of that tomorrow :smile:

GrayJack commented 4 years ago

I had the time to review the code again today, again I didn't see anything to worry about, I just noted some stuff not following naming convention in Rust and the lack of tests :smile:

Can you also add some tests?

KaindlJulian commented 4 years ago

Fixed the mentioned function names, gonna add tests in the next few days :smile:

KaindlJulian commented 4 years ago

I added tests for argument parsing. Don't really know how to test the stuff that depends on file metadata. Do you have any ideas @GrayJack ?

GrayJack commented 4 years ago

I have no idea yet, I've been looking for something to tests these cases, if you're agree, I'll merge this and if you add more tests, make a new pull request

KaindlJulian commented 4 years ago

Yea sounds good :+1: