Graylog2 / collector-sidecar

Manage log collectors through Graylog
https://www.graylog.org/
Other
268 stars 56 forks source link

Add version info to Windows executable. #417

Closed malcyon closed 2 years ago

malcyon commented 2 years ago

Adds version info to graylog-sidecar Windows executable using goversioninfo

Fixes #359

malcyon commented 2 years ago

Seems to work fine if I run make build-windows32.

image

malcyon commented 2 years ago

Tested successfully on a Windows 10 VM, using the EXE from the Jenkins build:

image

malcyon commented 2 years ago

Just need to do something with versioninfo.json, so that we don't have to update the version in multiple places with each release.

malcyon commented 2 years ago

Here is what it looks like using the command line flags instead of the json file:

image